[ovs-dev] [PATCHv17 1/2] ovs-thread: Add pthread spin lock support.

Ilya Maximets i.maximets at samsung.com
Fri Jul 19 14:46:48 UTC 2019


On 18.07.2019 21:03, Ben Pfaff wrote:
> On Wed, Jul 17, 2019 at 01:23:33PM -0700, William Tu wrote:
>> --- a/include/openvswitch/thread.h
>> +++ b/include/openvswitch/thread.h
>> @@ -17,6 +17,8 @@
>>  #ifndef OPENVSWITCH_THREAD_H
>>  #define OPENVSWITCH_THREAD_H 1
>>  
>> +#include <config.h>
> 
> That shouldn't be there.  Every .c file should already have #include
> <config.h> as its first (non-comment) line.
> 
> Otherwise,
> Acked-by: Ben Pfaff <blp at ovn.org>
> 
> 

Thanks William and Ben!

I applied my diff, dropped config.h, removed redundant sentence from the
commit message and pushed this to master.

Best regards, Ilya Maximets.


More information about the dev mailing list