[ovs-dev] [PATCH 2/3] upcall: Change should_revalidate to use max-revalidator value

Roi Dayan roid at mellanox.com
Sun Jul 21 08:34:22 UTC 2019


From: Vlad Buslov <vladbu at mellanox.com>

Revalidate if dump duration was longer than half of max-revalidator
timeout, instead of hardcoded 200msec value.

Signed-off-by: Vlad Buslov <vladbu at mellanox.com>
Acked-by: Roi Dayan <roid at mellanox.com>
---
 ofproto/ofproto-dpif-upcall.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c
index b3598742b4d1..00c8e6ddcfaa 100644
--- a/ofproto/ofproto-dpif-upcall.c
+++ b/ofproto/ofproto-dpif-upcall.c
@@ -2040,7 +2040,7 @@ should_revalidate(const struct udpif *udpif, uint64_t packets,
         return true;
     }
 
-    if (udpif->dump_duration < 200) {
+    if (udpif->dump_duration < ofproto_max_revalidator / 2) {
         /* We are likely to handle full revalidation for the flows. */
         return true;
     }
-- 
2.7.0



More information about the dev mailing list