[ovs-dev] [PATCHv2] system-traffic: Make nsh test more robust.

[William Tu]

On Mon, Jul 22, 2019 at 01:38:58PM +0300, Ilya Maximets wrote:
> On 19.07.2019 17:49, William Tu wrote:
> > The patch adds '-n' to tcpdump to avoid address coverting. Add '-l' for rhel8
> > to avoid buffering. Since '-U' is used to output to stdout, simply use 'cat'
> > to search result.  Use OVS_WAIT_UNTIL instead of sleep, and also remove/add
> > some newlines. Finally, move tcpdump captured interface into the namespace,
> > (capture p1 instead of ovs-p1), and tested using af_xdp.
> > 
> > Signed-off-by: William Tu <u9012063 at gmail.com>
> > ---
> > v2:
> >   - add '-l' for rhel
> >   - move tcpdump into namespace
> >   - fix comments, remove stderr redirect
> > ---
> 
> Thanks, William!
> 
> This fixes NSH tests on all my platforms.
> 
> Since this is the test only fix, this should be OK to apply while we're in a
> "soft freeze" especially because these tests never really worked for userspace.
> So, I fixed one redundant stderr redirection and applied to master.
> 
> Best regards, Ilya Maximets.
> 
Thanks