[ovs-dev] [PATCH] netdev-afxdp: Fix use of unconfigured device.

William Tu u9012063 at gmail.com
Mon Jul 22 18:10:31 UTC 2019

On Mon, Jul 22, 2019 at 05:08:48PM +0300, Ilya Maximets wrote:
> In case of failure of 'xsk_configure_all()', 'n_rxq' and 'xdpmode'
> will remain in a new state. This will result in successful
> reconfiguration (immediate return, because configuration is already
> applied) if 'netdev_reconfigure()' will be called again.
> Same issue was fixed previously for netdev-dpdk using 'dev->started'
> flag in commit:
> 606f66507250 ("netdev-dpdk: Don't use PMD driver if not configured successfully")
> Let's use similar approach with checking the 'dev->xsks' which only
> exists if configuration was successful.
> Additionally implemented 'netdev_afxdp_construct()' function to
> explicitly initialize all the specific fields and request the
> reconfiguration.
> CC: William Tu <u9012063 at gmail.com>
> Fixes: 0de1b425962d ("netdev-afxdp: add new netdev type for AF_XDP.")
> Signed-off-by: Ilya Maximets <i.maximets at samsung.com>

LGTM, thanks for the fix.

Acked-by: William Tu <u9012063 at gmail.com>


More information about the dev mailing list