[ovs-dev] [PATCH] committer-responsibilities: Add guidelines for fixing up mistakes.

Ben Pfaff blp at ovn.org
Thu Jul 25 03:09:25 UTC 2019


On Wed, Jul 24, 2019 at 08:25:54PM +0300, Ilya Maximets wrote:
> On 24.07.2019 20:05, Ben Pfaff wrote:
> > Signed-off-by: Ben Pfaff <blp at ovn.org>
> > ---
> > Based on an off-lst discussion with Ilya.  This is just my first, off-hand
> > thought on the topic.  Feedback welcome!
> 
> We could also consider suggesting a git hook like that:
> ---
> $ cat .git/hooks/pre-push
> #!/bin/bash
> 
> remote=$1
> protected_remote='upstream'
> 
> if [ $protected_remote != $remote ]; then exit 0; fi
> 
> echo "You're about to push to $protected_remote."
> 
> read -p "Do you want to proceed? [y|n] " reply < /dev/tty
> if echo $reply | grep -E '^[Yy]$' > /dev/null; then exit 0; fi
> 
> exit 1
> ---

Have you tried this?  How does it work for you in practice?


More information about the dev mailing list