[ovs-dev] [PATCH 03/12] ovs-vsctl: Add datapath and CT zone commands.

William Tu u9012063 at gmail.com
Fri Jul 26 15:04:44 UTC 2019


On Thu, Jul 25, 2019 at 04:24:05PM -0700, Yi-Hung Wei wrote:
> From: William Tu <u9012063 at gmail.com>
> 
> The patch adds the following commands
>   $ ovs-vsctl {add,del,list}-dp
> for creating/deleting/listing the datapath, and
>   $ ovs-vsctl {add,del,list}-zone-tp
> for conntrack zones and timeout policies.
> 
> Signed-off-by: William Tu <u9012063 at gmail.com>
> ---
>  tests/ovs-vsctl.at       |  20 +++-
>  utilities/ovs-vsctl.8.in |  29 ++++++
>  utilities/ovs-vsctl.c    | 245 +++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 292 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/ovs-vsctl.at b/tests/ovs-vsctl.at
> index 77604c58a2bc..8854138ecb1e 100644
> --- a/tests/ovs-vsctl.at
> +++ b/tests/ovs-vsctl.at
> @@ -805,6 +805,22 @@ AT_CHECK(
>    [RUN_OVS_VSCTL([--if-exists remove netflow x targets '"1.2.3.4:567"'])])
>  AT_CHECK(
>    [RUN_OVS_VSCTL([--if-exists clear netflow x targets])])
> +
> +AT_CHECK([RUN_OVS_VSCTL([add-dp netdev])])
> +AT_CHECK([RUN_OVS_VSCTL([add-dp system])])
> +AT_CHECK([RUN_OVS_VSCTL([add-zone-tp netdev zone=1 icmp_first=1 icmp_reply=2])])
> +AT_CHECK([RUN_OVS_VSCTL([list-zone-tp netdev])], [0], [Zone:1, Timeout Policies: icmp_first=1 icmp_reply=2
> +])
> +AT_CHECK([RUN_OVS_VSCTL([add-zone-tp netdev zone=2 icmp_first=2 icmp_reply=3])])
> +AT_CHECK([RUN_OVS_VSCTL([list-zone-tp netdev])], [0], [Zone:1, Timeout Policies: icmp_first=1 icmp_reply=2
> +Zone:2, Timeout Policies: icmp_first=2 icmp_reply=3
> +])
> +AT_CHECK([RUN_OVS_VSCTL([del-zone-tp netdev zone=1])])
> +AT_CHECK([RUN_OVS_VSCTL([list-zone-tp netdev])], [0], [Zone:2, Timeout Policies: icmp_first=2 icmp_reply=3
> +])
> +AT_CHECK([RUN_OVS_VSCTL([del-dp netdev])])
> +AT_CHECK([RUN_OVS_VSCTL([list-dp | sed 's/ uuid.*$//'])], [0], [system
> +])
>  OVS_VSCTL_CLEANUP
>  AT_CLEANUP
>  

I realize I should add more test cases here.
The above has only positive checks, I will add negative checks.

<snip>

Thanks
William



More information about the dev mailing list