[ovs-dev] [PATCH] [ovn-northd] Don't emit ICMP need to frag on LRP with no IPv4 address

Numan Siddique nusiddiq at redhat.com
Tue Jul 30 04:24:51 UTC 2019


On Fri, Jul 26, 2019 at 1:52 AM Mark Michelson <mmichels at redhat.com> wrote:

> LGTM
>
> Acked-by: Mark Michelson <mmichels at redhat.com>
>
> On 7/25/19 11:38 AM, Daniel Alvarez wrote:
> > Prior to this patch, when a LRP has only IPv6 addresses, ovn-northd
> > will crash (SIGSEV) because the current code injects a flow to
> > emit the ICMP need-to-frag from its IPv4 address which does not
> > exist.
> >
> > This patch is adding a check to skip the flow installation in case
> > the port does not have any IPv4 address.
> >
> > Signed-off-by: Daniel Alvarez <dalvarez at redhat.com>
>

Thanks. I applied this to master.

Can you please submit a back port patch to branch 2.12 ? I think we need
this fix.

Thanks
Numan


> > ---
> >   ovn/northd/ovn-northd.c | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c
> > index eb6c47cad..3542ba72f 100644
> > --- a/ovn/northd/ovn-northd.c
> > +++ b/ovn/northd/ovn-northd.c
> > @@ -7705,7 +7705,8 @@ build_lrouter_flows(struct hmap *datapaths, struct
> hmap *ports,
> >               for (size_t i = 0; i < od->nbr->n_ports; i++) {
> >                   struct ovn_port *rp = ovn_port_find(ports,
> >
>  od->nbr->ports[i]->name);
> > -                if (!rp || rp == od->l3dgw_port) {
> > +                if (!rp || rp == od->l3dgw_port ||
> > +                    !rp->lrp_networks.ipv4_addrs) {
> >                       continue;
> >                   }
> >                   ds_clear(&match);
> >
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>


More information about the dev mailing list