[ovs-dev] [PATCH] test: do not require python2 for CHECK_CONNTRACK macro

Mark Michelson mmichels at redhat.com
Tue Jul 30 17:31:08 UTC 2019


Why do these macros require python at all?

On 7/29/19 7:48 AM, Lorenzo Bianconi wrote:
> Do not strictly require python2 for CHECK_CONNTRACK macro definitions in
> system-{kmod,userspace}-macros.at
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi at redhat.com>
> ---
>   tests/system-kmod-macros.at      | 2 +-
>   tests/system-userspace-macros.at | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/system-kmod-macros.at b/tests/system-kmod-macros.at
> index 554a61e9b..48e94642b 100644
> --- a/tests/system-kmod-macros.at
> +++ b/tests/system-kmod-macros.at
> @@ -59,7 +59,7 @@ m4_define([CONFIGURE_VETH_OFFLOADS],
>   # kernel conntrack tables when the test is finished.
>   #
>   m4_define([CHECK_CONNTRACK],
> -    [AT_SKIP_IF([test $HAVE_PYTHON2 = no])
> +    [AT_SKIP_IF([test $HAVE_PYTHON = no])
>        m4_foreach([mod], [[nf_conntrack_ipv4], [nf_conntrack_ipv6], [nf_nat_ftp],
>                           [nf_nat_tftp]],
>                   [modprobe mod || echo "Module mod not loaded."
> diff --git a/tests/system-userspace-macros.at b/tests/system-userspace-macros.at
> index 9d5f3bf41..a411e3d89 100644
> --- a/tests/system-userspace-macros.at
> +++ b/tests/system-userspace-macros.at
> @@ -65,7 +65,7 @@ m4_define([CONFIGURE_VETH_OFFLOADS],
>   # Perform requirements checks for running conntrack tests.
>   #
>   m4_define([CHECK_CONNTRACK],
> -    [AT_SKIP_IF([test $HAVE_PYTHON2 = no])]
> +    [AT_SKIP_IF([test $HAVE_PYTHON = no])]
>   )
>   
>   # CHECK_CONNTRACK_ALG()
> 



More information about the dev mailing list