[ovs-dev] [PATCH] ofproto-dpif-xlate: Do not use zero-weight buckets in select groups.

[Ben Pfaff]

I sent v2:
https://mail.openvswitch.org/pipermail/ovs-dev/2019-June/359582.html

On Fri, Jun 07, 2019 at 03:55:36PM -0700, Ben Pfaff wrote:
> Weights are significant only for "select" groups;
> group_first_live_bucket() is used to pick a bucket only for
> "fast-failover" groups.  So I think that this is correct for group
> selection now.
> 
> However, group_is_alive() also uses group_first_live_bucket() for
> determining whether a group is alive, and for that purpose it should
> consider the group type whereas currently it just treats every group as
> if it was a fast-failover group.
> 
> I'll fix that and send a v2.
> 
> On Fri, Jun 07, 2019 at 03:27:28PM -0700, Yifeng Sun wrote:
> > Hi Ben,
> > 
> > group_first_live_bucket() can still return zero-weighted bucket, then
> > this bucket will
> > be used via pick_ff_group() and xlate_group_action__(). I am wondering
> > if it is an
> > issue?
> > 
> > Thanks,
> > Yifeng
> > 
> > On Fri, Jun 7, 2019 at 12:04 PM 0-day Robot <robot at bytheb.org> wrote:
> > >
> > > Bleep bloop.  Greetings Ben Pfaff, I am a robot and I have tried out your patch.
> > > Thanks for your contribution.
> > >
> > > I encountered some error that I wasn't expecting.  See the details below.
> > >
> > >
> > > checkpatch:
> > > WARNING: Line is 88 characters long (recommended limit is 79)
> > > #23 FILE: ofproto/ofproto-dpif-xlate.c:1:
> > > /* Copyright (c) 2009, 2010, 2011, 2012, 2013, 2014, 2015, 2016, 2017, 2019 Nicira, Inc.
> > >
> > > Lines checked: 47, Warnings: 1, Errors: 0
> > >
> > >
> > > Please check this out.  If you feel there has been an error, please email aconole at bytheb.org
> > >
> > > Thanks,
> > > 0-day Robot
> > > _______________________________________________
> > > dev mailing list
> > > dev at openvswitch.org
> > > https://mail.openvswitch.org/mailman/listinfo/ovs-dev