[ovs-dev] [PATCH 4/5] net: core: dev: Add extack argument to dev_change_flags()

[Yi-Hung Wei]

On Mon, Jun 10, 2019 at 4:45 PM Yifeng Sun <pkusunyifeng at gmail.com> wrote:
>
> From: Petr Machata <petrm at mellanox.com>
>
> Upstream commit:
>     commit 567c5e13be5cc74d24f5eb54cf353c2e2277189b
>     Author: Petr Machata <petrm at mellanox.com>
>     Date:   Thu Dec 6 17:05:42 2018 +0000
>
>     net: core: dev: Add extack argument to dev_change_flags()
>
>     In order to pass extack together with NETDEV_PRE_UP notifications, it's
>     necessary to route the extack to __dev_open() from diverse (possibly
>     indirect) callers. One prominent API through which the notification is
>     invoked is dev_change_flags().
>
>     Therefore extend dev_change_flags() with and extra extack argument and
>     update all users. Most of the calls end up just encoding NULL, but
>     several sites (VLAN, ipvlan, VRF, rtnetlink) do have extack available.
>
>     Since the function declaration line is changed anyway, name the other
>     function arguments to placate checkpatch.
>
>     Signed-off-by: Petr Machata <petrm at mellanox.com>
>     Acked-by: Jiri Pirko <jiri at mellanox.com>
>     Reviewed-by: Ido Schimmel <idosch at mellanox.com>
>     Reviewed-by: David Ahern <dsahern at gmail.com>
>     Signed-off-by: David S. Miller <davem at davemloft.net>
>
> This patch backports the above upstream patch and also adds fixes
> in compat code.
>
> Cc: Petr Machata <petrm at mellanox.com>
> Signed-off-by: Yifeng Sun <pkusunyifeng at gmail.com>
> ---
LGTM.

Acked-by: Yi-Hung Wei <yihung.wei at gmail.com>