[ovs-dev] [PATCH v3] ovn-controller: Omit alert for Port_Binding.external_ids changes

nusiddiq at redhat.com nusiddiq at redhat.com
Wed Jun 26 14:16:25 UTC 2019


From: Numan Siddique <nusiddiq at redhat.com>

Running the command "ovn-nbctl set logical_switch_port foo external_ids:foo=bar"
results in the incremetal processing engine to recompute the flows on the
chassis where the logical port 'foo' is claimed.

This patch avoids this unnecessary recomputation by omitting the alert for the
Port_Binding.external_ids column.

Signed-off-by: Numan Siddique <nusiddiq at redhat.com>
Acked-by: Han Zhou <hzhou8 at ebay.com>
---

v2 -> v3
------
  * Based on the review comments from Han, dropped p2 and p3 from the series.

 ovn/controller/ovn-controller.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/ovn/controller/ovn-controller.c b/ovn/controller/ovn-controller.c
index 60190161f..ddfd05c71 100644
--- a/ovn/controller/ovn-controller.c
+++ b/ovn/controller/ovn-controller.c
@@ -1732,6 +1732,8 @@ main(int argc, char *argv[])
 
     ovsdb_idl_track_add_all(ovnsb_idl_loop.idl);
     ovsdb_idl_omit_alert(ovnsb_idl_loop.idl, &sbrec_chassis_col_nb_cfg);
+    ovsdb_idl_omit_alert(ovnsb_idl_loop.idl,
+                         &sbrec_port_binding_col_external_ids);
     update_sb_monitors(ovnsb_idl_loop.idl, NULL, NULL, NULL);
 
     stopwatch_create(CONTROLLER_LOOP_STOPWATCH_NAME, SW_MS);
-- 
2.21.0



More information about the dev mailing list