[ovs-dev] [PATCH] dpdk: Fix case-sensitivity of dpdk-init knob.

Ian Stokes ian.stokes at intel.com
Fri Mar 1 13:27:39 UTC 2019


On 3/1/2019 11:59 AM, Ilya Maximets wrote:
> Before supporting the DPDK initialization status in DB 'dpdk-init' was
> just a boolean and 'smap_get_bool', which is case-insensitive, was used
> to get the value.
> 
> Current code uses simple 'strcmp' that fails to recognize values like
> "True". As a result this breaks different OVS configuration tools.
> For example, kolla-ansible uses 'other_config:dpdk-init=True' but OVS
> is not able to recognize it leading to broken installations.
> 
> 'strcasecmp' should be used instead to fix the issue.
> 

Good catch, applied to master, backported to 2.11 and 2.10.

Ian


More information about the dev mailing list