[ovs-dev] [ovs-discuss] [PATCH ] ofproto: Fix for ovs-vswitchd crash on flow-mod with unsupported action
Ben Pfaff
blp at ovn.org
Tue Mar 5 23:20:13 UTC 2019
On Tue, Mar 05, 2019 at 06:15:54PM +0530, parameswaran krishnamurthy wrote:
> Problem Description:
> The ovs-vswitchd is crashing while invoking flow-mod with upsupported
> action(Tested with ovs2.10.1)
Thanks for the patch. I simplified it a little and applied it to
master, as appended.
You implied that you're using a non-standard ofproto provider. Is that
correct?
Thanks,
Ben.
diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index 40949eec933e..40780e2766ab 100644
--- a/ofproto/ofproto.c
+++ b/ofproto/ofproto.c
@@ -5652,9 +5652,7 @@ modify_flows_init_loose(struct ofproto *ofproto,
(fm->flags & OFPUTIL_FF_NO_READONLY) != 0);
/* Must create a new flow in advance for the case that no matches are
* found. Also used for template for multiple modified flows. */
- add_flow_init(ofproto, ofm, fm);
-
- return 0;
+ return add_flow_init(ofproto, ofm, fm);
}
/* Implements OFPFC_MODIFY. Returns 0 on success or an OpenFlow error code on
@@ -5737,9 +5735,7 @@ modify_flow_init_strict(struct ofproto *ofproto OVS_UNUSED,
(fm->flags & OFPUTIL_FF_NO_READONLY) != 0);
/* Must create a new flow in advance for the case that no matches are
* found. Also used for template for multiple modified flows. */
- add_flow_init(ofproto, ofm, fm);
-
- return 0;
+ return add_flow_init(ofproto, ofm, fm);
}
/* Implements OFPFC_MODIFY_STRICT. Returns 0 on success or an OpenFlow error
More information about the dev
mailing list