[ovs-dev] [PATCH v6 0/3] Move offloading code into a new file

Ilya Maximets i.maximets at samsung.com
Wed Mar 6 15:18:17 UTC 2019


On 05.03.2019 19:49, Ophir Munk wrote:
> Hardware offloading code is moved to a new file called
> netdev-rte-offloads.c. The original offloading code is copied as is
> from the netdev-dpdk.c file to the new file where future
> offloading code should be added as well.
> The new code is refactored based on code styling.
> 
> This series is essential for offloading code development for the following
> reasons:
> 1. This series does not change the existing OVS code flows/logic on master branch.
> OVS functionality is the same before and after this series.
> 2. The separation is essential for new offloading code
> development without interfering with the rest of OVS development.
> 3. Vice versa: it is essential that while developing offloading code - 
> to be able to frequently rebase on top of master branch.
> 4. The OVS-kernel is practicing the same approach. Please note the file lib/netdev-tc-offloads.c.
> 
> Based on the points mentioned above we kindly ask that the series will be
> applied on top of the master branch.
> 
> Ophir Munk (1):
>   netdev-rte-offloads: Rename netdev_dpdk_* functions
> 
> Roni Bar Yanai (2):
>   netdev-dpdk: Expose flow creation/destruction calls
>   netdev-dpdk: Move offloading code to a new file
> 
>  lib/automake.mk           |   4 +-
>  lib/netdev-dpdk.c         | 708 ++------------------------------------------
>  lib/netdev-dpdk.h         |  17 ++
>  lib/netdev-rte-offloads.c | 733 ++++++++++++++++++++++++++++++++++++++++++++++
>  lib/netdev-rte-offloads.h |  40 +++
>  5 files changed, 810 insertions(+), 692 deletions(-)
>  create mode 100644 lib/netdev-rte-offloads.c
>  create mode 100644 lib/netdev-rte-offloads.h

I had no chance to check this in runtime, but the code looks OK.

Acked-by: Ilya Maximets <i.maximets at samsung.com>

BTW, Ophir, you probably need to add yourself as a co-author to the first patch.

> 
> v1:
> Initial release
> v2:
> Rebase on top of master branch + remove extra spaces, see
> https://patchwork.ozlabs.org/patch/1044187/
> v3:
> Rebase on top of master branch
> Code rafactored based on v2 reviews and coding style
> v4:
> Rebase on top of master branch
> Updates based on v3 reviews
> v5:
> Updates based on v4 reviews
> v6:
> Rebase on top of master branch
> Remove multiple consecutive blank lines
> 


More information about the dev mailing list