[ovs-dev] [PATCH 2/2] dpctl: Change log level for dubug information.

Ben Pfaff blp at ovn.org
Fri Mar 15 21:05:59 UTC 2019


Doesn't seem particularly useful to me, I suggest that we remove it
entirely instead.

On Fri, Mar 15, 2019 at 06:21:40PM +0300, Ilya Maximets wrote:
> s/dubug/debug/
> 
> On 15.03.2019 17:06, Ilya Maximets wrote:
> > This information is useful only for parser debugging.
> > No need to print it each time to the logs.
> > 
> > CC: Ben Pfaff <blp at ovn.org>
> > Fixes: d1fd1ea91242 ("ovs-dpctl: New --names option to use port names in flow dumps.")
> > Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
> > ---
> >  lib/dpctl.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/lib/dpctl.c b/lib/dpctl.c
> > index edb753cb4..d60ce1e73 100644
> > --- a/lib/dpctl.c
> > +++ b/lib/dpctl.c
> > @@ -2584,8 +2584,8 @@ dpctl_unixctl_handler(struct unixctl_conn *conn, int argc, const char *argv[],
> >      if (!set_names) {
> >          dpctl_p.names = dpctl_p.verbosity > 0;
> >      }
> > -    VLOG_INFO("set_names=%d verbosity=%d names=%d", set_names,
> > -              dpctl_p.verbosity, dpctl_p.names);
> > +    VLOG_DBG("set_names=%d verbosity=%d names=%d", set_names,
> > +             dpctl_p.verbosity, dpctl_p.names);
> >  
> >      if (!error) {
> >          dpctl_command_handler *handler = (dpctl_command_handler *) aux;
> > 


More information about the dev mailing list