[ovs-dev] [PATCH v2] dpctl: Drop parser debug information.

Ilya Maximets i.maximets at samsung.com
Mon Mar 18 11:02:30 UTC 2019


This information is not that useful.
Anyway, no need to print it each time to the logs.

CC: Ben Pfaff <blp at ovn.org>
Fixes: d1fd1ea91242 ("ovs-dpctl: New --names option to use port names in flow dumps.")
Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
---

Version 2:
    * Logs removed instead of changing to DBG.

 lib/dpctl.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/lib/dpctl.c b/lib/dpctl.c
index edb753cb4..9c4eb65d9 100644
--- a/lib/dpctl.c
+++ b/lib/dpctl.c
@@ -51,8 +51,6 @@
 #include "util.h"
 #include "openvswitch/ofp-flow.h"
 #include "openvswitch/ofp-port.h"
-#include "openvswitch/vlog.h"
-VLOG_DEFINE_THIS_MODULE(dpctl);
 
 typedef int dpctl_command_handler(int argc, const char *argv[],
                                   struct dpctl_params *);
@@ -2584,8 +2582,6 @@ dpctl_unixctl_handler(struct unixctl_conn *conn, int argc, const char *argv[],
     if (!set_names) {
         dpctl_p.names = dpctl_p.verbosity > 0;
     }
-    VLOG_INFO("set_names=%d verbosity=%d names=%d", set_names,
-              dpctl_p.verbosity, dpctl_p.names);
 
     if (!error) {
         dpctl_command_handler *handler = (dpctl_command_handler *) aux;
-- 
2.17.1



More information about the dev mailing list