[ovs-dev] [PATCH] netdev-tc-offloads: Improve log message for icmpv6 offload not supported

Simon Horman simon.horman at netronome.com
Mon Mar 18 13:59:19 UTC 2019


On Mon, Mar 18, 2019 at 09:39:00AM +0100, Simon Horman wrote:
> On Sun, Mar 17, 2019 at 02:29:45PM +0000, Roi Dayan wrote:
> > 
> > 
> > On 01/03/2019 02:26, Gregory Rose wrote:
> > > 
> > > 
> > > On 2/28/2019 11:29 AM, Moshe Levi wrote:
> > >> Signed-off-by: Moshe Levi <moshele at mellanox.com>
> > >> ---
> > >>   lib/netdev-tc-offloads.c |    4 ++--
> > >>   1 files changed, 2 insertions(+), 2 deletions(-)
> > >>
> > >> diff --git a/lib/netdev-tc-offloads.c b/lib/netdev-tc-offloads.c
> > >> index 36bce15..e65f5b9 100644
> > >> --- a/lib/netdev-tc-offloads.c
> > >> +++ b/lib/netdev-tc-offloads.c
> > >> @@ -1015,12 +1015,12 @@ test_key_and_mask(struct match *match)
> > >>                  key->nw_proto == IPPROTO_ICMPV6) {
> > >>           if (mask->tp_src) {
> > >>               VLOG_DBG_RL(&rl,
> > >> -                        "offloading attribute icmp_type isn't supported");
> > >> +                        "offloading attribute icmpv6_type isn't supported");
> > >>               return EOPNOTSUPP;
> > >>           }
> > >>           if (mask->tp_dst) {
> > >>               VLOG_DBG_RL(&rl,
> > >> -                        "offloading attribute icmp_code isn't supported");
> > >> +                        "offloading attribute icmpv6_code isn't supported");
> > >>               return EOPNOTSUPP;
> > >>           }
> > >>       } else if (key->dl_type == htons(OFP_DL_TYPE_NOT_ETH_TYPE)) {
> > > 
> > > Nice catch...
> > > 
> > > LGTM
> > > 
> > > Reviewed-by: Greg Rose <gvrose8192 at gmail.com>
> > > 
> > 
> > +simon
> > maybe missed it.
> 
> Thanks, I see it now.

Thanks again.

I have pushed this change to: master, branch-2.11, branch-2.10, branch-2.9
and branch-2.8.


More information about the dev mailing list