[ovs-dev] [PATCHv7] netdev-afxdp: add new netdev type for AF_XDP.

Ilya Maximets i.maximets at samsung.com
Mon May 6 14:32:23 UTC 2019


On 03.05.2019 22:02, William Tu wrote:
> +static struct xsk_socket_info *
> +xsk_configure(int ifindex, int xdp_queue_id, int xdpmode)
> +{
> +    struct xsk_socket_info *xsk;
> +    struct xsk_umem_info *umem;
> +    void *bufs;
> +    int ret;
> +
> +    /* umem memory region */
> +    ret = posix_memalign(&bufs, getpagesize(),
> +                         NUM_FRAMES * FRAME_SIZE);

Please, use 'get_page_size()' from lib/util.h instead of 'getpagesize()'
here and in other places. 'getpagesize()' is not portable.

Best regards, Ilya Maximets.


More information about the dev mailing list