[ovs-dev] [PATCH v8 4/5] dpif-netdev: refactor generic implementation
Ilya Maximets
i.maximets at samsung.com
Wed May 8 14:45:59 UTC 2019
On 08.05.2019 17:44, Van Haaren, Harry wrote:
>> -----Original Message-----
>> From: Ilya Maximets [mailto:i.maximets at samsung.com]
>> Sent: Wednesday, May 8, 2019 3:20 PM
>> To: Van Haaren, Harry <harry.van.haaren at intel.com>; ovs-dev at openvswitch.org
>> Cc: Stokes, Ian <ian.stokes at intel.com>; aconole at redhat.com;
>> echaudro at redhat.com
>> Subject: Re: [PATCH v8 4/5] dpif-netdev: refactor generic implementation
>
> <snip>
>
>>> static void
>>> @@ -7556,6 +7567,7 @@ dpcls_destroy_subtable(struct dpcls *cls, struct
>> dpcls_subtable *subtable)
>>> cmap_remove(&cls->subtables_map, &subtable->cmap_node,
>>> subtable->mask.hash);
>>> cmap_destroy(&subtable->rules);
>>> + ovsrcu_postpone(free, subtable->mf_masks);
>>> ovsrcu_postpone(free, subtable);
>>> }
>>
>>
>> This is not current master. You need to rebase.
>> Please, pay attention to recent subtables related commit:
>> 0fcf0776c72a ("Double postponing to free subtables.")
>
> Correct - thanks for the pointer. Indeed during the rebase I've added the actual free of the mf_masks as a double-postponed call too.
>
>
>> Best regards, Ilya Maximets.
>
> I'll post v9 very shortly, which includes the count_1bits() feedback as per other email.
Please, also use:
lib/compiler.h:#define ALWAYS_INLINE __attribute__((always_inline))
More information about the dev
mailing list