[ovs-dev] [PATCH 1/1] dpdk: Use DPDK 18.11.1 release.

[Ian Stokes]

On 5/2/2019 12:15 PM, Kevin Traynor wrote:
> On 24/04/2019 18:03, Ian Stokes wrote:
>> Modify travis linux build script to use the latest
>> DPDK stable release 18.11.1. Update docs for latest
>> DPDK stable releases.
>>
>> Signed-off-by: Ian Stokes <ian.stokes at intel.com>
>> ---
>>   .travis/linux-build.sh                   | 2 +-
>>   Documentation/faq/releases.rst           | 4 ++--
>>   Documentation/intro/install/dpdk.rst     | 8 ++++----
>>   Documentation/topics/dpdk/vhost-user.rst | 6 +++---
>>   4 files changed, 10 insertions(+), 10 deletions(-)
>>
>> diff --git a/.travis/linux-build.sh b/.travis/linux-build.sh
>> index 0cf5da6af..d869713f7 100755
>> --- a/.travis/linux-build.sh
>> +++ b/.travis/linux-build.sh
>> @@ -89,7 +89,7 @@ fi
>>   
>>   if [ "$DPDK" ] || [ "$DPDK_SHARED" ]; then
>>       if [ -z "$DPDK_VER" ]; then
>> -        DPDK_VER="18.11"
>> +        DPDK_VER="18.11.1"
> 
> Looks like there's logic to handle the the dpdk-stable- dir prefix in
> the travis prep code, and if it's been run through travis then it must
> be ok.

Yes. The function install_dpdk below will take the version we request 
and execute wget https://fast.dpdk.org/rel/dpdk-$DPDK_VER.tar.xz. The 
logic happens after that with the folloiwng

         tar xvf dpdk-$1.tar.xz > /dev/null
         DIR_NAME=$(tar -tf dpdk-$1.tar.xz | head -1 | cut -f1 -d"/")
         if [ $DIR_NAME != "dpdk-$1"  ]; then mv $DIR_NAME dpdk-$1; fi

So we should be ok.

> 
>>       fi
>>       install_dpdk $DPDK_VER
>>       if [ "$CC" = "clang" ]; then
>> diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst
>> index cd5aad162..6c5949b33 100644
>> --- a/Documentation/faq/releases.rst
>> +++ b/Documentation/faq/releases.rst
>> @@ -173,11 +173,11 @@ Q: What DPDK version does each Open vSwitch release work with?
>>       2.4.x        2.0
>>       2.5.x        2.2
>>       2.6.x        16.07.2
>> -    2.7.x        16.11.8
>> +    2.7.x        16.11.9
> 
> Not strictly part of this change, but maybe you could update the 17.11's
> too (if they are ready) and add a generic comment in the commit message
> to say updating docs for other new stable releases.

Good point, Yes I was going to wait until the 17.11.6 release was ready, 
  it was at rc1 at the time of testing, there was validation issues with 
17.11.5 so I think the decision was to hold off until 17.11.6. I was 
thinking we could update at a later stage when 17.11.6 is ready.

> 
>>       2.8.x        17.05.2
>>       2.9.x        17.11.4
>>       2.10.x       17.11.4
>> -    2.11.x       18.11
>> +    2.11.x       18.11.1
>>       ============ =======
>>   
>>   Q: Are all the DPDK releases that OVS versions work with maintained?
>> diff --git a/Documentation/intro/install/dpdk.rst b/Documentation/intro/install/dpdk.rst
>> index 344d2b3a6..32b40c391 100644
>> --- a/Documentation/intro/install/dpdk.rst
>> +++ b/Documentation/intro/install/dpdk.rst
>> @@ -42,7 +42,7 @@ Build requirements
>>   In addition to the requirements described in :doc:`general`, building Open
>>   vSwitch with DPDK will require the following:
>>   
>> -- DPDK 18.11
>> +- DPDK 18.11.1
>>   
>>   - A `DPDK supported NIC`_
>>   
>> @@ -71,9 +71,9 @@ Install DPDK
>>   #. Download the `DPDK sources`_, extract the file and set ``DPDK_DIR``::
>>   
>>          $ cd /usr/src/
>> -       $ wget http://fast.dpdk.org/rel/dpdk-18.11.tar.xz
>> -       $ tar xf dpdk-18.11.tar.xz
>> -       $ export DPDK_DIR=/usr/src/dpdk-18.11
>> +       $ wget http://fast.dpdk.org/rel/dpdk-18.11.1.tar.xz
>> +       $ tar xf dpdk-18.11.1.tar.xz
>> +       $ export DPDK_DIR=/usr/src/dpdk-18.11.1
> 
> export DPDK_DIR=/usr/src/dpdk-stable-18.11.1

Yes, good catch.
> 
>>          $ cd $DPDK_DIR
>>   
>>   #. (Optional) Configure DPDK as a shared library
>> diff --git a/Documentation/topics/dpdk/vhost-user.rst b/Documentation/topics/dpdk/vhost-user.rst
>> index 993797de5..483e228e4 100644
>> --- a/Documentation/topics/dpdk/vhost-user.rst
>> +++ b/Documentation/topics/dpdk/vhost-user.rst
>> @@ -320,9 +320,9 @@ To begin, instantiate a guest as described in :ref:`dpdk-vhost-user` or
>>   DPDK sources to VM and build DPDK::
>>   
>>       $ cd /root/dpdk/
>> -    $ wget http://fast.dpdk.org/rel/dpdk-18.11.tar.xz
>> -    $ tar xf dpdk-18.11.tar.xz
>> -    $ export DPDK_DIR=/root/dpdk/dpdk-18.11
>> +    $ wget http://fast.dpdk.org/rel/dpdk-18.11.1.tar.xz
>> +    $ tar xf dpdk-18.11.1.tar.xz
>> +    $ export DPDK_DIR=/root/dpdk/dpdk-18.11.1
> 
> export DPDK_DIR=/usr/src/dpdk-stable-18.11.1

Good catch, will change for the v2.

Thanks
Ian
> 
>>       $ export DPDK_TARGET=x86_64-native-linuxapp-gcc
>>       $ export DPDK_BUILD=$DPDK_DIR/$DPDK_TARGET
>>       $ cd $DPDK_DIR
>>
>