[ovs-dev] [PATCH] ovn: Properly set the index for chassis lookup

Numan Siddique nusiddiq at redhat.com
Fri May 10 08:58:41 UTC 2019


On Thu, May 9, 2019 at 1:40 PM Dumitru Ceara <dceara at redhat.com> wrote:

> The chassis_lookup_by_name function now calls
> sbrec_chassis_index_set_name instead of sbrec_chassis_set_name. Due to
> the use of the wrong API memory was leaked every time a chassis was
> looked up by name. This was mostly visible when chassis lookups had to
> be done continuously (e.g., when two chassis were misconfigured
> with the same system-id).
>
> Reported-at: https://bugzilla.redhat.com/1698462
> Reported-by: Alexander <alerom at rambler.ru>
> Signed-off-by: Dumitru Ceara <dceara at redhat.com>
> ---
>

Acked-by: Numan Siddique <nusiddiq at redhat.com>


>  ovn/lib/chassis-index.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ovn/lib/chassis-index.c b/ovn/lib/chassis-index.c
> index 34d4a31..423eeee 100644
> --- a/ovn/lib/chassis-index.c
> +++ b/ovn/lib/chassis-index.c
> @@ -30,7 +30,7 @@ chassis_lookup_by_name(struct ovsdb_idl_index
> *sbrec_chassis_by_name,
>  {
>      struct sbrec_chassis *target = sbrec_chassis_index_init_row(
>          sbrec_chassis_by_name);
> -    sbrec_chassis_set_name(target, name);
> +    sbrec_chassis_index_set_name(target, name);
>
>      struct sbrec_chassis *retval = sbrec_chassis_index_find(
>          sbrec_chassis_by_name, target);
> --
> 1.8.3.1
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>


More information about the dev mailing list