[ovs-dev] [PATCH 2/2] fedora: Handle upgrades from rhel package.

[Ansis Atteka]

On Fri, 10 May 2019 at 14:47, Guru Shetty <guru at ovn.org> wrote:
>>>
>>>
>>> > +    # daemons. Another "restart" (outside the package postinst script) is
>>> > +    # needed to actually run new daemons.
>>> > +    if [ -e "%{_tmppath}/ovs-upgrade-from-sysv" ]; then
>>> t seems that if rpm package that was built from rhel spec file was
>>> removed (without upgrade) and then you do fresh install, then you hit
>>> this upgrade path too. Unless the whole host was rebooted before fresh
>>> install and all contents of /tmp directory were purged. Though this
>>> may not be an issue after invoking the "sytemctl enable", right?
>>
>>
>> You are correct. I had not thought about it. The end result is that we have a start of openvswitch daemons. I think I can fix this by making this code only run during an upgrade. I will send a v2.
>>
>
> I may have misunderstood your comment. When we uninstall the previous package and then we do a fresh install, the "/etc/init.d/openvswitch" will not be there and we will not create %{_tmppath}/ovs-upgrade-from-sysv.  So we will not restart openvswitch. I hope we are on the same page.
>


You are right. The %pre of the new package creates this file in tmp.
For strange reasons I overlooked something and incorrectly assumed
that it is %preun of the old package that creates it (which would be
impossible btw because that is code we have already shipped). So:

Acked-by: Ansis Atteka <aatteka at ovn.org>

Sorry for raising false alarm.