[ovs-dev] [PATCH v3 0/3] netdev: Dynamic per-port Flow API + Offload Split Up.

[Roi Dayan]

On 14/05/2019 11:33, Ilya Maximets wrote:
> On 14.05.2019 8:53, Roi Dayan wrote:
>> On 07/05/2019 12:24, Ilya Maximets wrote:
>>> This is the combined patch-set for dynamic flow API along with
>>> the further work about splitting up netdev offloading from the
>>> generic netdev related code and making different netdev flow
>>> offloading implementations more or less consistent.
>>>
>>> Version 3:
>>>   * Fixed uninitialized 'error' in provider register function.
>>>   * Fixed opposite bahaviour of .init_flow_api for dpdk due
>>>     to wrong bool to int conversion.
>>>   * Sanity checked with all 3 available offload providers:
>>>     dummy, tc and dpdk.
>>>
>>> Version 2:
>>>   * No functional changes.
>>>   * Patches combined in a single patch-set.
>>>   * Fixed non-alphabetical order of files in mk file.
>>>   * Added Acks from Ben.
>>>
>>> For patch #1 since RFC:
>>>   * Fixed sparce build.
>>>   * Some logs turned from INFO to DBG.
>>>   * Enabled HW offloading on non-Linux systems
>>>     (For testing with dummy provider).
>>>
>>>
>>> Ilya Maximets (3):
>>>   netdev: Dynamic per-port Flow API.
>>>   netdev: Split up netdev offloading to separate module.
>>>   netdev-offload: Rename offload providers.
>>>
>>>  lib/automake.mk                               |   9 +-
>>>  lib/dpdk.c                                    |   2 +
>>>  lib/dpif-netdev.c                             |   1 +
>>>  lib/dpif-netlink.c                            |   1 +
>>>  lib/netdev-dpdk.c                             |  25 +-
>>>  lib/netdev-dpdk.h                             |   3 +
>>>  lib/netdev-dummy.c                            |  24 +-
>>>  lib/netdev-linux.c                            |   3 -
>>>  lib/netdev-linux.h                            |  10 -
>>>  ...v-rte-offloads.c => netdev-offload-dpdk.c} |  56 +-
>>>  lib/netdev-offload-provider.h                 | 105 +++
>>>  ...tdev-tc-offloads.c => netdev-offload-tc.c} |  42 +-
>>>  lib/netdev-offload.c                          | 658 ++++++++++++++++++
>>>  lib/netdev-offload.h                          | 126 ++++
>>>  lib/netdev-provider.h                         |  88 +--
>>>  lib/netdev-rte-offloads.h                     |  57 --
>>>  lib/netdev-tc-offloads.h                      |  44 --
>>>  lib/netdev-vport.c                            |   6 +-
>>>  lib/netdev.c                                  | 465 +------------
>>>  lib/netdev.h                                  |  57 --
>>>  tests/dpif-netdev.at                          |   4 +-
>>>  tests/ofproto-macros.at                       |   1 -
>>>  vswitchd/bridge.c                             |   1 +
>>>  23 files changed, 1026 insertions(+), 762 deletions(-)
>>>  rename lib/{netdev-rte-offloads.c => netdev-offload-dpdk.c} (93%)
>>>  create mode 100644 lib/netdev-offload-provider.h
>>>  rename lib/{netdev-tc-offloads.c => netdev-offload-tc.c} (98%)
>>>  create mode 100644 lib/netdev-offload.c
>>>  create mode 100644 lib/netdev-offload.h
>>>  delete mode 100644 lib/netdev-rte-offloads.h
>>>  delete mode 100644 lib/netdev-tc-offloads.h
>>>
>>
>>
>> Hi,
>>
>> I fail to apply the patches over latest master branch.
>> can you rebase over latest master?
> 
> Hi. That is strange. Do you have some local patches that conflicts with
> this series? 'git am' applies it perfectly on my system:
> 
> $ wget https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.ozlabs.org%2Fseries%2F106519%2Fmbox%2F&data=02%7C01%7Croid%40mellanox.com%7C6a20ba54c7974faf394008d6d846ce05%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636934195970865836&sdata=iCfNz7GMUmLe9UKlqhrkf0c1%2Bkq68TbnE7SRIs58jUs%3D&reserved=0 --content-disposition
> --2019-05-14 11:29:26--  https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.ozlabs.org%2Fseries%2F106519%2Fmbox%2F&data=02%7C01%7Croid%40mellanox.com%7C6a20ba54c7974faf394008d6d846ce05%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636934195970865836&sdata=iCfNz7GMUmLe9UKlqhrkf0c1%2Bkq68TbnE7SRIs58jUs%3D&reserved=0
> 2019-05-14 11:29:31 (39,5 KB/s) - ‘netdev-Dynamic-per-port-Flow-API-Offload-Split-Up..patch’ saved [128720/128720]
> 
> $ git checkout upstream/master -b test
> 
> $ git am netdev-Dynamic-per-port-Flow-API-Offload-Split-Up..patch
> Applying: netdev: Dynamic per-port Flow API.
> Applying: netdev: Split up netdev offloading to separate module.
> Applying: netdev-offload: Rename offload providers.
> 
> $ git hist -10
> * fdcb2d3ea 2019-05-07 | netdev-offload: Rename offload providers. (HEAD -> test) [Ilya Maximets]
> * 5114905c7 2019-05-07 | netdev: Split up netdev offloading to separate module. [Ilya Maximets]
> * 7d10d9e3f 2019-05-07 | netdev: Dynamic per-port Flow API. [Ilya Maximets]
> * d58b59c17 2019-05-10 | datapath: Support kernel version 4.19.x and 4.20.x (upstream/master) [Yifeng Sun]
> 
> Best regards, Ilya Maximets.
> 

thanks. there was something wrong with my repo. i did git reset hard and it solved the issue.