[ovs-dev] [PATCH] conntrack: add display support for sctp

[Aaron Conole]

0-day Robot <robot at bytheb.org> writes:

> Bleep bloop.  Greetings Aaron Conole, I am a robot and I have tried out your patch.
> Thanks for your contribution.
>
> I encountered some error that I wasn't expecting.  See the details below.
>
>
> build:
> mv -f $depbase.Tpo $depbase.Plo
> libtool: compile:  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror -Werror -g -O2 -MT lib/netdev-tc-offloads.lo -MD -MP -MF lib/.deps/netdev-tc-offloads.Tpo -c lib/netdev-tc-offloads.c -o lib/netdev-tc-offloads.o
> depbase=`echo lib/netlink-conntrack.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
> /bin/sh ./libtool  --tag=CC   --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I.    -I ./include -I ./include -I ./lib -I ./lib    -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror -Werror   -g -O2 -MT lib/netlink-conntrack.lo -MD -MP -MF $depbase.Tpo -c -o lib/netlink-conntrack.lo lib/netlink-conntrack.c &&\
> mv -f $depbase.Tpo $depbase.Plo
> libtool: compile:  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror -Werror -g -O2 -MT lib/netlink-conntrack.lo -MD -MP -MF lib/.deps/netlink-conntrack.Tpo -c lib/netlink-conntrack.c -o lib/netlink-conntrack.o
> In file included from lib/netlink-conntrack.h:22:0,
>                  from lib/netlink-conntrack.c:19:
> lib/ct-dpif.h:105:39: error: redeclaration of enumerator 'SCTP_CONNTRACK_SHUTDOWN_ACK_SENT'
>  #define SCTP_CONNTRACK_HEARTBEAT_SENT SCTP_CONNTRACK_SHUTDOWN_ACK_SENT+1
>                                        ^
> In file included from lib/netlink-conntrack.c:27:0:
> /usr/include/linux/netfilter/nf_conntrack_sctp.h:15:2: note: previous definition of 'SCTP_CONNTRACK_SHUTDOWN_ACK_SENT' was here
>   SCTP_CONNTRACK_SHUTDOWN_ACK_SENT,
>   ^
> In file included from lib/netlink-conntrack.h:22:0,
>                  from lib/netlink-conntrack.c:19:
> lib/ct-dpif.h:105:71: error: expected ',' or '}' before '+' token
>  #define SCTP_CONNTRACK_HEARTBEAT_SENT SCTP_CONNTRACK_SHUTDOWN_ACK_SENT+1
>                                                                        ^
> make[2]: *** [lib/netlink-conntrack.lo] Error 1
> make[2]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace'
> make: *** [all] Error 2
>

Whoops - thanks robot!

> Please check this out.  If you feel there has been an error, please email aconole at bytheb.org
>
> Thanks,
> 0-day Robot