[ovs-dev] [PATCH] Add support for DHCP option 15 - domain name

Maciej Jozefczyk mjozefcz at redhat.com
Mon May 27 09:01:40 UTC 2019


Hello!

>> What's the full story?

I found that option not used in code. It was only used in parser tests, but
with the same flag number - 15 as domain_name.
https://tools.ietf.org/html/rfc2132
As per RFC I decided to rename it in tests and add its support to the code.

Should I add some note to the commit message even the code itself was not
changed?

Thanks!
Maciej

On Fri, May 24, 2019 at 7:21 PM Numan Siddique <nusiddiq at redhat.com> wrote:

>
>
> On Fri, May 24, 2019 at 10:26 PM Ben Pfaff <blp at ovn.org> wrote:
>
>> On Tue, May 21, 2019 at 02:13:03PM +0200, mjozefcz at redhat.com wrote:
>> > From: Maciej Józefczyk <mjozefcz at redhat.com>
>> >
>> > For Openstack Internal DNS functionality we need
>> > to provide support for domain_name option.
>> >
>> > Signed-off-by: Maciej Józefczyk <mjozefcz at redhat.com>
>>
>> This seems to be a little different from just adding support for a new
>> DHCP option, because in some places it's renaming an existing "domain"
>> option to "domain_name".  That may introduce a cross-version
>> compatibility issue.  If it does, then it would be better to retain the
>> existing name.
>>
>> What's the full story?
>>
>
> Oops. I never noticed the test code deleting the option - "domain" and
> adding "domain_name".
>
> I looked into the code now and this is what has happened. We never
> supported the dhcp
> option 15 (domain_name) earlier and this patch adds the support for this
> option.
> But the initial commit [1] which added the DHCP support in OVN has added
> the option 15 with the
> name - "domain" in the test-ovn.c. I think it was a mistake from my side
> to add that option in the
> test code even though we never supported that option. My mistake. I think
> I might have added that
> option in the test code (but not in the actual list) is probably to test
> the action - put_dhcp_opts
> with an option of type "str".
>
> [1] -
> https://github.com/openvswitch/ovs/commit/42814145d70c77462ce28b38841cd160f0486776#diff-e3335c87e2c9ad67b3d403e4f4361771R253
>
> Thanks
> Numan
>
>
>> Thanks,
>>
>> Ben.
>> _______________________________________________
>> dev mailing list
>> dev at openvswitch.org
>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>>
>

-- 
Best regards,
Maciej Józefczyk


More information about the dev mailing list