[ovs-dev] [PATCH 2/3] sparse: Re-allow sparse builds with dpdk.

Ilya Maximets i.maximets at samsung.com
Tue May 28 16:23:05 UTC 2019


On 28.05.2019 19:16, 0-day Robot wrote:
> Bleep bloop.  Greetings Ilya Maximets, I am a robot and I have tried out your patch.
> Thanks for your contribution.
> 
> I encountered some error that I wasn't expecting.  See the details below.
> 
> 
> checkpatch:
> WARNING: Line has non-spaces leading whitespace
> #79 FILE: include/sparse/rte_flow.h:507:
> 	rte_be16_t inner_type; /**< Inner EtherType or TPID. */
> 
> WARNING: Line has non-spaces leading whitespace
> #87 FILE: include/sparse/rte_flow.h:513:
> 	.tci = RTE_BE16(0x0fff),
> 
> WARNING: Line has non-spaces leading whitespace
> #88 FILE: include/sparse/rte_flow.h:514:
> 	.inner_type = RTE_BE16(0x0000),
> 
> WARNING: Line has non-spaces leading whitespace
> #112 FILE: include/sparse/rte_flow.h:1090:
> 	enum rte_eth_hash_function func; /**< RSS hash function to apply. */
> 
> WARNING: Line has non-spaces leading whitespace
> #113 FILE: include/sparse/rte_flow.h:1091:
> 	/**
> 
> WARNING: Line has non-spaces leading whitespace
> #114 FILE: include/sparse/rte_flow.h:1092:
> 	 * Packet encapsulation level RSS hash @p types apply to.
> 
> WARNING: Line has non-spaces leading whitespace
> #115 FILE: include/sparse/rte_flow.h:1093:
> 	 *
> 
> WARNING: Line has non-spaces leading whitespace
> #116 FILE: include/sparse/rte_flow.h:1094:
> 	 * - @p 0 requests the default behavior. Depending on the packet
> 
> WARNING: Line has non-spaces leading whitespace
> #117 FILE: include/sparse/rte_flow.h:1095:
> 	 *   type, it can mean outermost, innermost, anything in between or
> 
> WARNING: Line has non-spaces leading whitespace
> #118 FILE: include/sparse/rte_flow.h:1096:
> 	 *   even no RSS.
> 
> WARNING: Line has non-spaces leading whitespace
> #119 FILE: include/sparse/rte_flow.h:1097:
> 	 *
> 
> WARNING: Line has non-spaces leading whitespace
> #120 FILE: include/sparse/rte_flow.h:1098:
> 	 *   It basically stands for the innermost encapsulation level RSS
> 
> WARNING: Line has non-spaces leading whitespace
> #121 FILE: include/sparse/rte_flow.h:1099:
> 	 *   can be performed on according to PMD and device capabilities.
> 
> WARNING: Line has non-spaces leading whitespace
> #122 FILE: include/sparse/rte_flow.h:1100:
> 	 *
> 
> WARNING: Line has non-spaces leading whitespace
> #123 FILE: include/sparse/rte_flow.h:1101:
> 	 * - @p 1 requests RSS to be performed on the outermost packet
> 
> WARNING: Line has non-spaces leading whitespace
> #124 FILE: include/sparse/rte_flow.h:1102:
> 	 *   encapsulation level.
> 
> WARNING: Line has non-spaces leading whitespace
> #125 FILE: include/sparse/rte_flow.h:1103:
> 	 *
> 
> WARNING: Line has non-spaces leading whitespace
> #126 FILE: include/sparse/rte_flow.h:1104:
> 	 * - @p 2 and subsequent values request RSS to be performed on the
> 
> WARNING: Line has non-spaces leading whitespace
> #127 FILE: include/sparse/rte_flow.h:1105:
> 	 *   specified inner packet encapsulation level, from outermost to
> 
> WARNING: Line has non-spaces leading whitespace
> #128 FILE: include/sparse/rte_flow.h:1106:
> 	 *   innermost (lower to higher values).
> 
> WARNING: Line has non-spaces leading whitespace
> #129 FILE: include/sparse/rte_flow.h:1107:
> 	 *
> 
> WARNING: Line has non-spaces leading whitespace
> #130 FILE: include/sparse/rte_flow.h:1108:
> 	 * Values other than @p 0 are not necessarily supported.
> 
> WARNING: Line has non-spaces leading whitespace
> #131 FILE: include/sparse/rte_flow.h:1109:
> 	 *
> 
> WARNING: Line has non-spaces leading whitespace
> #132 FILE: include/sparse/rte_flow.h:1110:
> 	 * Requesting a specific RSS level on unrecognized traffic results
> 
> WARNING: Line has non-spaces leading whitespace
> #133 FILE: include/sparse/rte_flow.h:1111:
> 	 * in undefined behavior. For predictable results, it is recommended
> 
> WARNING: Line has non-spaces leading whitespace
> #134 FILE: include/sparse/rte_flow.h:1112:
> 	 * to make the flow rule pattern match packet headers up to the
> 
> WARNING: Line has non-spaces leading whitespace
> #135 FILE: include/sparse/rte_flow.h:1113:
> 	 * requested encapsulation level so that only matching traffic goes
> 
> WARNING: Line has non-spaces leading whitespace
> #136 FILE: include/sparse/rte_flow.h:1114:
> 	 * through.
> 
> WARNING: Line has non-spaces leading whitespace
> #137 FILE: include/sparse/rte_flow.h:1115:
> 	 */
> 
> WARNING: Line has non-spaces leading whitespace
> #138 FILE: include/sparse/rte_flow.h:1116:
> 	uint32_t level;
> 
> WARNING: Line has non-spaces leading whitespace
> #139 FILE: include/sparse/rte_flow.h:1117:
> 	uint64_t types; /**< Specific RSS hash types (see ETH_RSS_*). */
> 
> WARNING: Line has non-spaces leading whitespace
> #140 FILE: include/sparse/rte_flow.h:1118:
> 	uint32_t key_len; /**< Hash key length in bytes. */
> 
> WARNING: Line has non-spaces leading whitespace
> #141 FILE: include/sparse/rte_flow.h:1119:
> 	uint32_t queue_num; /**< Number of entries in @p queue. */
> 
> WARNING: Line has non-spaces leading whitespace
> #142 FILE: include/sparse/rte_flow.h:1120:
> 	const uint8_t *key; /**< Hash key. */
> 
> WARNING: Line has non-spaces leading whitespace
> #143 FILE: include/sparse/rte_flow.h:1121:
> 	const uint16_t *queue; /**< Queue indices to use. */
> 
> Lines checked: 207, Warnings: 35, Errors: 0
> 
> 
> Please check this out.  If you feel there has been an error, please email aconole at bytheb.org

This header is partial copy of DPDK header with different coding style.
Fix for the checkpatch script available here:

    https://patchwork.ozlabs.org/patch/1106364/

Best regards, Ilya Maximets.


More information about the dev mailing list