[ovs-dev] [PATCH] netdev-dpdk: Print the reason of device detaching failure.
Stokes, Ian
ian.stokes at intel.com
Thu May 30 07:45:46 UTC 2019
> Useful for debugging.
>
> Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
> ---
> lib/netdev-dpdk.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
> index cc15df65c..4856c56aa 100644
> --- a/lib/netdev-dpdk.c
> +++ b/lib/netdev-dpdk.c
> @@ -1394,8 +1394,11 @@ netdev_dpdk_destruct(struct netdev *netdev)
> * device are closed.
> */
> if (!remove_on_close || !netdev_dpdk_get_num_ports(rte_dev)) {
> - if (rte_dev_remove(rte_dev) < 0) {
> - VLOG_ERR("Device '%s' can not be detached", dev-
> >devargs);
> + int ret = rte_dev_remove(rte_dev);
> +
> + if (ret < 0) {
> + VLOG_ERR("Device '%s' can not be detached: %s.",
> + dev->devargs, rte_strerror(-ret));
> } else {
> /* Device was closed and detached. */
> VLOG_INFO("Device '%s' has been removed and detached",
LGTM, ACKED.
Ian
More information about the dev
mailing list