[ovs-dev] [PATCH] ip_gre: Remove even more unused code

Ilya Maximets i.maximets at ovn.org
Fri Nov 1 08:27:41 UTC 2019


On 31.10.2019 23:46, Greg Rose wrote:
> There is a confusing mix of ipgre and gretap functions with some
> needed for gretap still having ipgre_ prefixes.  This time though
> I think I got the rest of the unused ipgre code.
> 
> Fixes: d5822f428814 ("gre: Remove dead ipgre code")
> Signed-off-by: Greg Rose <gvrose8192 at gmail.com>
> ---
>   datapath/linux/compat/ip_gre.c | 38 --------------------------------------
>   1 file changed, 38 deletions(-)

Hi.

This broke build with kernel 4.15.18:
https://travis-ci.org/openvswitch/ovs/jobs/605766364

datapath/linux/ip_gre.c: In function ‘ipgre_tunnel_init’:
datapath/linux/ip_gre.c:940:22: error: ‘ipgre_header_ops’ undeclared (first use in this function)
    dev->header_ops = &ipgre_header_ops;
                       ^
datapath/linux/ip_gre.c:940:22: note: each undeclared identifier is reported only once for each function it appears in
datapath/linux/ip_gre.c: At top level:
datapath/linux/ip_gre.c:925:12: warning: ‘ipgre_tunnel_init’ defined but not used [-Wunused-function]
  static int ipgre_tunnel_init(struct net_device *dev)
             ^
datapath/linux/ip_gre.c:946:20: warning: ‘ipgre_xmit’ defined but not used [-Wunused-function]
  static netdev_tx_t ipgre_xmit(struct sk_buff *skb,
                     ^

Best regards, Ilya Maximets.


More information about the dev mailing list