[ovs-dev] [PATCH] ip_gre: Removed unused ipgre netdev ops

Gregory Rose gvrose8192 at gmail.com
Fri Nov 1 16:02:43 UTC 2019


On 11/1/2019 8:48 AM, Gregory Rose wrote:
>
> On 11/1/2019 7:50 AM, Simon Horman wrote:
>> On Thu, Oct 31, 2019 at 03:18:23PM -0700, Gregory Rose wrote:
>>> On 10/31/2019 2:08 PM, Ben Pfaff wrote:
>>>> On Thu, Oct 31, 2019 at 01:30:39PM -0700, Greg Rose wrote:
>>>>> When cleaning up unused ipgre code the ipgre_netdev_ops structure
>>>>> was missed. Get rid of it now.
>>>>>
>>>>> Fixes: d5822f428814 ("gre: Remove dead ipgre code")
>>>>> Signed-off-by: Greg Rose <gvrose8192 at gmail.com>
>>>> Applied to master, thanks!
>>> Oh, I guess you didn't see my request to hold off on this.  No worries.
>>>
>>> I'll send a follow up patch with some more code to be excised.
>>>
>>> And thanks for the quick response!
>> This appears to break travis-ci.
>>
>> https://travis-ci.org/openvswitch/ovs/builds/605766351
>
> OK, it passed here
> https://travis-ci.org/gvrose8192/ovs-experimental/builds/605736578
>
> Let me check what happened.
>
> - Greg

So the patch that got applied yesterday is not the patch that I pushed 
to test travis.  ipgre_tunnel_init and ipgre_xmit
also supposed to be deleted.  Let's revert the old patch and start 
over.  I have no idea what happened.

- Greg



More information about the dev mailing list