[ovs-dev] [PATCH v2] ofp-monitor: Fixed the usage of 'usable_protocols' variable in 'parse_flow_monitor_request' function.

Ben Pfaff blp at ovn.org
Fri Nov 1 21:36:40 UTC 2019


On Tue, Jul 23, 2019 at 01:02:10PM -0700, Ashish Varma wrote:
> 'usable_protocols' is now getting set to OFPUTIL_P_OF10_ANY on return from
> 'parse_flow_monitor_request' function. The calling function now checks for the
> value in this variable against the 'allowed_protocols' variable.
> Also a check is added for a match field which is not supported in OpenFlow 1.0
> and return an error.
> Modified the man page of ovs-ofctl to reflect Flow Monitor support as
> OpenFlow 1.0 Nicira extension only.
> 
> Signed-off-by: Ashish Varma <ashishvarma.ovs at gmail.com>
> ---
> v1-v2:
> Added a test that triggers the error condition fixed in this patch.
> Setting the usable_protocols variable to OFPUTIL_P_OF10_ANY or even a
> further subset if the match field requires it to. e.g. 'sctp_dst' is supported
> as only NXM protocol and not in STD protocol.
> Consistent wording for the error message on encountering an unusable flow
> format.

Thanks.  I applied this to master.


More information about the dev mailing list