[ovs-dev] [PATCH] lib/tc: Fix flow dump for tunnel id equal zero

Simon Horman simon.horman at netronome.com
Mon Nov 4 08:50:09 UTC 2019


On Sun, Nov 03, 2019 at 08:08:00AM +0000, Roi Dayan wrote:
> 
> 
> On 2019-11-02 1:27 PM, Simon Horman wrote:
> > On Fri, Nov 01, 2019 at 03:54:49PM +0100, Simon Horman wrote:
> >> On Wed, Oct 30, 2019 at 02:40:35PM +0200, Roi Dayan wrote:
> >>> From: Dmytro Linkin <dmitrolin at mellanox.com>
> >>>
> >>> Tunnel id 0 is not printed unless tunnel flag FLOW_TNL_F_KEY is set.
> >>> Fix that by always setting FLOW_TNL_F_KEY when tunnel id is valid.
> >>>
> >>> Fixes: 0227bf092ee6 ("lib/tc: Support optional tunnel id")
> >>> Signed-off-by: Dmytro Linkin <dmitrolin at mellanox.com>
> >>> Reviewed-by: Roi Dayan <roid at mellanox.com>
> >>
> >> Hi Roi,
> >>
> >> this looks fine to me but I am holding off on pushing it
> >> until master passes travis-ci again.
> >>
> >> It also seems to backport cleanly to branch-2.11 and I plan
> > 
> > s/11/12/
> > 
> >> to apply it there too.
> > 
> > I have now pushed this patch to master and branch-2.12.
> > 
> >>
> >> If it is suitable for older branches could you please post a
> >> backport/backports?
> 
> The fix is not relevant for other branches as the original commit
> to support tunnel id 0 is also not in other branches.
> We treated this as a feature and didn't add to old branches.

Thanks Roi,

got it.


More information about the dev mailing list