[ovs-dev] [PATCHv4] ofproto-dpif: Expose datapath capability to ovsdb.

William Tu u9012063 at gmail.com
Wed Nov 6 20:35:49 UTC 2019


On Tue, Nov 05, 2019 at 04:49:10PM -0800, Ben Pfaff wrote:
> On Tue, Nov 05, 2019 at 02:57:46PM -0800, William Tu wrote:
> > +    /* ODP_SUPPORT_FIELDS */
> > +    str_value = xasprintf("%"PRIuSIZE, odp.max_vlan_headers);
> > +    smap_add(cap, "max_vlan_headers", str_value);
> > +    free(str_value);
> 
> I think that you can shorten the above to:
>     smap_add_format(cap, "max_vlan_headers", "%"PRIuSIZE, odp.max_vlan_headers);
> and similarly for other cases.

Yes, thank you.
> 
> I think that we can improve the documentation.  I'm working on a
> suggestion for that, please give me a while to write it up.

Sure, I will wait.

--William


More information about the dev mailing list