[ovs-dev] [PATCH v2] netdev-dpdk: Track vhost tx contention.

Ilya Maximets i.maximets at ovn.org
Fri Nov 8 23:05:29 UTC 2019


On 08.11.2019 9:30, David Marchand wrote:
> On Tue, Nov 5, 2019 at 4:37 PM Ilya Maximets <i.maximets at ovn.org> wrote:
>>>> That's an interesting debug method, but it looks not very suitable
>>>> for an end-user documentation.  One thing that bothers me the most
>>>> is referencing C code snippets in this kind of documentation.
>>>
>>> Ok, can we conclude on the coverage counter wrt the v1 then?
>>> https://patchwork.ozlabs.org/patch/1153238/
>>>
>>> Should I submit a v3 with the doc update (but removing the parts about perf) ?
>>
>> 'perf' part should not be there.
>>
>> I'm in doubt about the rest of the docs.  This part might be useful, but
>> it doesn't provide any solution for the problem and I really don't know
>> if there is something we can suggest in that case.  "Rework your network
>> topology" doesn't sound like a friendly solution or exact steps to do.
>>
>> One more thing is that documenting coverage counters doesn't look like a
>> good idea to me and I'd like to not create a precedent.
>>
>> One day we'll rework this to be some "PMD/netdev performance statistics"
>> and it'll be OK to document it.  But there is nothing more permanent
>> than a temporary solution.
>>
>> Right now the easiest way for me is to just apply v1.
> 
> Ok for me.

OK. I'll apply v1 then.

Best regards, Ilya Maximets.


More information about the dev mailing list