[ovs-dev] [PATCH v3] dpdk: Migrate to the new pdump API.

David Marchand david.marchand at redhat.com
Tue Nov 12 17:15:32 UTC 2019


On Tue, Nov 12, 2019 at 6:07 PM Stokes, Ian <ian.stokes at intel.com> wrote:
> On 11/11/2019 3:01 PM, Ilya Maximets wrote:
> > DPDK commit 660098d61f57 ("pdump: use generic multi-process channel")
> > switched pdump to use generic DPDK IPC instead of sockets.
> > Old API was deprecated and removed.  Updating OVS code accordingly.
> >
> > Signed-off-by: Ilya Maximets <i.maximets at ovn.org>
>
> Thanks for the patch Ilya.
>
> I see compilation passing now on dpdk-latest with this applied.
>
> https://travis-ci.org/istokes/ovs/builds/610915636
>
> I still had issues with running PDUMP, but those issues are specific to
> PDUMP setup in my environment. A separate issue we can discuss further
> on the deprecation thread as it seems unrelated to this patch.
>
> @David, are you happy to ack the patch (I see some of the changes are
> from your side).

I did not work on the crash I saw, but it was most likely a problem on my side.
This looks good to me.

Acked-by: David Marchand <david.marchand at redhat.com>


--
David Marchand



More information about the dev mailing list