[ovs-dev] [PATCH v3 ovn 0/3] Improve ovn-detrace support for parsing OpenFlow cookies.

[Mark Michelson]

For the series:

Acked-by: Mark Michelson <mmichels at redhat.com>

On 11/12/19 11:47 AM, Dumitru Ceara wrote:
> Commit eb25a7da639e ("Improve debuggability of OVN to OpenFlow translations.")
> added support for more types of cookies (partial SB uuids) that are stored
> in OpenFlow entries created by ovn-controller.
> 
> The last patch in this series implements support for parsing all these
> different cookies in ovn-detrace too.
> 
> The first patch is a bug fix required as ovn-detrace was broken after
> moving OVN to its own separate rundir.
> 
> The second patch fixes line parsing in ovn-detrace.
> 
> CC: Han Zhou <hzhou at ovn.org>
> Signed-off-by: Dumitru Ceara <dceara at redhat.com>
> 
> Dumitru Ceara (3):
>        ovn-detrace: Fix rundir.
>        ovn-detrace: Fix line parsing.
>        ovn-detrace: Add support for other types of SB cookies.
> 
> 
>   utilities/ovn-detrace.in |  215 +++++++++++++++++++++++++++++++---------------
>   1 file changed, 146 insertions(+), 69 deletions(-)
> 
> 
> ---
> v3:
> - Remove stray "%s".
> - Rename pprint to print_p to avoid name clashes with the library function.
> v2:
> - Address Mark's comments:
>    - properly handle potential collisions between cookie -> UUID mappings.
>    - when looking up SB records by cookie, match on the first part of the
>      UUID.
> - Further refactor ovn-detrace to simplify prefixing outputs.
> - Change print statements to print() calls.
>