[ovs-dev] [PATCH] compat: Add missing inline keyword

Gregory Rose gvrose8192 at gmail.com
Wed Nov 13 17:23:02 UTC 2019


On 11/5/2019 5:03 PM, Gregory Rose wrote:
>
> On 11/5/2019 3:14 PM, Ben Pfaff wrote:
>> On Tue, Nov 05, 2019 at 02:14:24PM -0800, Greg Rose wrote:
>>> The missing inline keyword before the definition of the
>>> rpl_nf_ct_tmpl_free() function causes spurious warnings about the
>>> function not being used on some older kernels.  Add the keyword
>>> to suppress the warning.
>>>
>>> Signed-off-by: Greg Rose <gvrose8192 at gmail.com>
>> The commit message and the patch make sense given my experience of GCC
>> behavior.  I haven't tested it.
>>
>> Acked-by: Ben Pfaff <blp at ovn.org>
>
> I only did a compile test of it on Travis.
>
> https://travis-ci.org/gvrose8192/ovs-experimental/builds/607794710
>
> There's one error but it's a resource or infrastructure issue I think.
>
> Thanks,
>
> - Greg

Pinging the maintainers...

This is a benign issue for now but if anyone ever tried to use 
rpl_nf_ct_tmpl_free in two different modules they'd
get a linker error.  That probably won't happen but it's still not correct.

Thanks,

- Greg


More information about the dev mailing list