[ovs-dev] [PATCH v4 ovn 0/3] Improve ovn-detrace support for parsing OpenFlow cookies.

[Han Zhou]

On Wed, Nov 13, 2019 at 1:51 AM Dumitru Ceara <dceara at redhat.com> wrote:
>
> Commit eb25a7da639e ("Improve debuggability of OVN to OpenFlow
translations.")
> added support for more types of cookies (partial SB uuids) that are stored
> in OpenFlow entries created by ovn-controller.
>
> The last patch in this series implements support for parsing all these
> different cookies in ovn-detrace too.
>
> The first patch is a bug fix required as ovn-detrace was broken after
> moving OVN to its own separate rundir.
>
> The second patch fixes line parsing in ovn-detrace.
>
> CC: Han Zhou <hzhou at ovn.org>
> Signed-off-by: Dumitru Ceara <dceara at redhat.com>
>
> Dumitru Ceara (3):
>       ovn-detrace: Fix rundir.
>       ovn-detrace: Fix line parsing.
>       ovn-detrace: Add support for other types of SB cookies.
>
>
>  utilities/ovn-detrace.in |  201
++++++++++++++++++++++++++++++++--------------
>  1 file changed, 138 insertions(+), 63 deletions(-)
>
>
> ---
> v4:
> - Address Han's comments:
>   - Fix printing of last logical flow information.
> - Added Acked-by from Mark on patches 1 & 3. I didn't add it to patch 2
>   because I significantly changed patch 2 in v4.
> v3:
> - Remove stray "%s".
> - Rename pprint to print_p to avoid name clashes with the library
function.
> v2:
> - Address Mark's comments:
>   - properly handle potential collisions between cookie -> UUID mappings.
>   - when looking up SB records by cookie, match on the first part of the
>     UUID.
> - Further refactor ovn-detrace to simplify prefixing outputs.
> - Change print statements to print() calls.
>

Thanks Dumitru. I applied the series to master.