[ovs-dev] [PATCH ovn] ovn-northd: Avoid empty address list when limiting ARP/ND broadcast.

[Numan Siddique]

On Thu, Nov 14, 2019 at 6:14 PM Dumitru Ceara <dceara at redhat.com> wrote:
>
> Reported-by: Numan Siddique <numans at ovn.org>
> Fixes: 32f5ebb06226 ("ovn-northd: Limit ARP/ND broadcast domain whenever possible.")
> Signed-off-by: Dumitru Ceara <dceara at redhat.com>

Thanks Dumitru for the fix. I applied this to master.

Thanks
Numan

> ---
>  northd/ovn-northd.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c
> index d6beb97..6742bc0 100644
> --- a/northd/ovn-northd.c
> +++ b/northd/ovn-northd.c
> @@ -5337,10 +5337,14 @@ build_lswitch_rport_arp_req_flows(struct ovn_port *op,
>          }
>      }
>
> -    build_lswitch_rport_arp_req_flow_for_ip(&all_ips_v4, AF_INET, sw_op,
> -                                            sw_od, 75, lflows);
> -    build_lswitch_rport_arp_req_flow_for_ip(&all_ips_v6, AF_INET6, sw_op,
> -                                            sw_od, 75, lflows);
> +    if (!sset_is_empty(&all_ips_v4)) {
> +        build_lswitch_rport_arp_req_flow_for_ip(&all_ips_v4, AF_INET, sw_op,
> +                                                sw_od, 75, lflows);
> +    }
> +    if (!sset_is_empty(&all_ips_v6)) {
> +        build_lswitch_rport_arp_req_flow_for_ip(&all_ips_v6, AF_INET6, sw_op,
> +                                                sw_od, 75, lflows);
> +    }
>
>      sset_destroy(&all_ips_v4);
>      sset_destroy(&all_ips_v6);
> --
> 1.8.3.1
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>