[ovs-dev] [PATCH v3] dpdk: Migrate to the new pdump API.

[Stokes, Ian]

On 11/13/2019 3:26 PM, Ilya Maximets wrote:
> On 13.11.2019 15:28, Stokes, Ian wrote:
>>
>>
>> On 11/12/2019 7:40 PM, Ilya Maximets wrote:
>>> On 12.11.2019 19:51, Stokes, Ian wrote:
>>>>
>>>>
>>>> On 11/12/2019 5:15 PM, David Marchand wrote:
>>>>> On Tue, Nov 12, 2019 at 6:07 PM Stokes, Ian <ian.stokes at intel.com> wrote:
>>>>>> On 11/11/2019 3:01 PM, Ilya Maximets wrote:
>>>>>>> DPDK commit 660098d61f57 ("pdump: use generic multi-process channel")
>>>>>>> switched pdump to use generic DPDK IPC instead of sockets.
>>>>>>> Old API was deprecated and removed.  Updating OVS code accordingly.
>>>>>>>
>>>>>>> Signed-off-by: Ilya Maximets <i.maximets at ovn.org>
>>>>>>
>>>>>> Thanks for the patch Ilya.
>>>>>>
>>>>>> I see compilation passing now on dpdk-latest with this applied.
>>>>>>
>>>>>> https://travis-ci.org/istokes/ovs/builds/610915636
>>>>>>
>>>>>> I still had issues with running PDUMP, but those issues are specific to
>>>>>> PDUMP setup in my environment. A separate issue we can discuss further
>>>>>> on the deprecation thread as it seems unrelated to this patch.
>>>>>>
>>>>>> @David, are you happy to ack the patch (I see some of the changes are
>>>>>> from your side).
>>>>>
>>>>> I did not work on the crash I saw, but it was most likely a problem on my side.
>>>>> This looks good to me.
>>>>
>>>>   From a some further testing on my side I'm also seeing a crash, specifically OVS crashes out once packets are received. PDUMP is still running but complains of being unable to communicate with the primary process and then exits. Is this similar to what you saw?
>>>>
>>>> @Ilya, by chance did you see anything like this?
>>>
>>>
>>> Honestly, I never tried to use pdump, and I don't really want to try
>>> preparing the setup for it (building ASLR disabled kernel and stuff).
>>>
>>
>> I haven't run it a while myself either. Typically use ovs-tcpdump.
>>
>>
>>>
>>>> I'll investigate further myself tomorrow. I was going to hold off on the merge in the meantime. Thoughts?
>>>
>>> There are 2 options here:
>>> 1. Apply this patch and hope that DPDK will be fixed someday.
>>>      + Optionally apply deprecation patch.
>>> 2. Completely remove pdump support now without prior deprecation
>>>      because it just doesn't work.
>> I'd like option 1, apply the patches & deprecate on dpdk-latest. This at least gets the dpdk-latest passing with rc2 for the moment (I'd do a rebase for ovs master with this also).
>>
>> Before removing pdump support completely I'd like to investigate further, if it can be confirmed to be a DPDK/OVS compatibility issue WRT the PMDs as David has suggested, then thats fine,  once confirmed I feel it would be fair to remove it completely then as it just doesn't work.
>>
>> Thoughts?
> 
> OK for me.
> 
Thanks, I've pushed this to dpdk-latest, I've also rebased dpdk-latest 
with ovs master (I had applied the pdump deprecation notice on OVS 
master already as there was no need to wait for 19.11 for that).

Thanks
Ian