[ovs-dev] [PATCH] compat: Add missing inline keyword

[Ben Pfaff]

On Wed, Nov 20, 2019 at 03:47:23PM -0800, Gregory Rose wrote:
> 
> On 11/20/2019 3:26 PM, Ben Pfaff wrote:
> > On Wed, Nov 13, 2019 at 09:23:02AM -0800, Gregory Rose wrote:
> > > On 11/5/2019 5:03 PM, Gregory Rose wrote:
> > > > On 11/5/2019 3:14 PM, Ben Pfaff wrote:
> > > > > On Tue, Nov 05, 2019 at 02:14:24PM -0800, Greg Rose wrote:
> > > > > > The missing inline keyword before the definition of the
> > > > > > rpl_nf_ct_tmpl_free() function causes spurious warnings about the
> > > > > > function not being used on some older kernels.  Add the keyword
> > > > > > to suppress the warning.
> > ...
> > 
> > > This is a benign issue for now but if anyone ever tried to use
> > > rpl_nf_ct_tmpl_free in two different modules they'd
> > > get a linker error.  That probably won't happen but it's still not correct.
> > Even without "inline", it's still declared "static", which means that it
> > can't duplicate symbols defined in other translation units.
> Well I meant in terms of making it not static.  But right, the protection
> against including the same header content saves us.
> 
> IMO functions in headers should be inlined but if we're not interested in
> this patch go ahead and drop it.  NBD to me.

It's the right thing to do, so I committed it.