[ovs-dev] [PATCH] dp-packet: Fix clearing/copying of memory layout flags.

Ilya Maximets i.maximets at ovn.org
Thu Nov 21 14:34:51 UTC 2019


On 21.11.2019 14:58, Ilya Maximets wrote:
> 'ol_flags' of DPDK mbuf could contain bits responsible for external
> or indirect buffers which are not actually offload flags in a common
> sense.  Clearing/copying of these flags could lead to memory leaks of
> external memory chunks and crashes due to access to wrong memory.
> 
> OVS should not clear these flags while resetting offloads and also
> should not copy them to the newly allocated packets.
> 
> This change is required to support DPDK 19.11, as some drivers may
> return mbufs with these flags set.  However, it might be good to do
> the same for DPDK 18.11, because these flags are present and should
> be taken into account.
> 
> Signed-off-by: Ilya Maximets <i.maximets at ovn.org>

We could also add the following tag:
Fixes: 03f3f9c0faf8 ("dpdk: Update to use DPDK 18.11.")

Best regards, Ilya Maximets.


More information about the dev mailing list