[ovs-dev] [PATCH v1] ovs container build: Make kernel module configurable

[Ben Pfaff]

On Tue, Nov 12, 2019 at 12:47:58AM -0800, amginwal at gmail.com wrote:
> -./configure --localstatedir="/var" --sysconfdir="/etc" --prefix="/usr" \
> +if [ $KERNEL_VERSION == "host" ]; then

Supporting == in [] or "test" is a GNUism.  Use = for wider support
(including BSD).

> +   ./configure --localstatedir="/var" --sysconfdir="/etc" --prefix="/usr" \
> +--enable-ssl
> +else
> +    ./configure --localstatedir="/var" --sysconfdir="/etc" --prefix="/usr" \
>  --with-linux=/lib/modules/$KERNEL_VERSION/build --enable-ssl
> +fi

There's a lot of duplication above, I'd suggest using variables to
reduce the duplication.