[ovs-dev] [PATCH] dpif-netdev: Use netdev-offload API for port lookup while offloading.

Ilya Maximets i.maximets at ovn.org
Sat Nov 30 12:07:26 UTC 2019


On 29.11.2019 15:46, Ophir Munk wrote:
> Hi Ilya,
> The first two RFC series are confirmed. They require the third RFC series to enable user space vport offloading. 
> 
> 1. https://patchwork.ozlabs.org/project/openvswitch/list/?series=143209
> ("netdev-offload: Prerequisites of vport offloading via DPDK")
> 
> 2. https://patchwork.ozlabs.org/project/openvswitch/list/?series=144559
> ("dpif-netdev: Use netdev-offload API for port lookup while offloading.")
> 
> 3. https://patchwork.ozlabs.org/project/openvswitch/list/?series=144826
> ("[ovs-dev,RFC,v1] netdev-dpdk: Add flow_api support for netdev vports") 
> 
> Can you please merge all the three series into one patch set?
> Then we will be able  to test it and send our feedback.

Hi.

This patch (series #2) is more like a bug fix that doesn't relate to vport
offloading.  I'd like it to be reviewed/ACKed as a standalone fix, so I
could push it directly to master.  After that I could rebase series #1.

I don't see the reason for changes in series #3, the doesn't make sense
for me without looking at your vport offloading code, so I'd suggest to make
it a part of your vport offlloading patch-set.  However, I'm suspecting that
you're going to use this similarly to what happens in there:
https://mail.openvswitch.org/pipermail/ovs-dev/2019-November/364931.html
So, you may take the same suggestion into account:
https://mail.openvswitch.org/pipermail/ovs-dev/2019-November/365294.html

Best regards, Ilya Maximets.


More information about the dev mailing list