[ovs-dev] [PATCH v2] tests: Add check for correct l3l4 conntrack frag reassembly

Gregory Rose gvrose8192 at gmail.com
Thu Oct 3 18:09:35 UTC 2019


On 10/3/2019 11:07 AM, Ben Pfaff wrote:
> On Thu, Oct 03, 2019 at 10:46:09AM -0700, Greg Rose wrote:
>> Two commits recently fixed an issue with setting the corrrect l3 and l4
>> flow information when conntrack reassembles packet fragments.
>>
>> c98f776 datapath: Clear the L4 portion of the key for "later" fragments
>> 2609173 datapath: Properly set L4 keys on "later" IP fragments
>>
>> This test checks for regressions that might break this feature.  It
>> counts on the fact that when the bug is present the udp src port
>> will not be correct.  It will either be zero or else some other
>> garbage value.  So the test feeds some fragments through for
>> reassembly and then checks to make sure that the udp srce port
>> is actually the correct value of 5001.
>>
>> Tested by reverting the above commits and observing that the test
>> then fails.---
>>
>> Signed-off-by: Greg Rose <gvrose8192 at gmail.com>
> Applied to master, thank you!

Awesome, thanks Ben!

I had a lot of fun writing that little test - figuring out the correct 
placement of those '[]' brackets caused some
consternation for me to say the least.  But it gave me a chance to read 
up on the autom4te documentation.

Fun stuff!

;^)

- Greg


More information about the dev mailing list