[ovs-dev] [PATCH v2] tests: Add check for correct l3l4 conntrack frag reassembly

Gregory Rose gvrose8192 at gmail.com
Fri Oct 4 16:51:20 UTC 2019



On 10/4/2019 7:53 AM, Gregory Rose wrote:
>
> On 10/4/2019 7:44 AM, Darrell Ball wrote:
>>
>>
>>
>> You need to add a macro to check applicability
>> for kernel, it will do nothing for check-kmod case; for full 
>> check-kernel support, 'if desired', you need to check for versions 
>> that have the fix
>> for userspace, it will unconditionally skip the test, although a 
>> comment explaining why would be helpful
>> see the example for CHECK_CT_DPIF_PER_ZONE_LIMIT which handles 
>> check-kmod vs check-system-userspace
>>
>> I noticed a couple other issues:
>>
>> The test is labeled "fragment reassembly test":
>>
>> a/ All the conntrack fragmentation tests include a reassembly aspect 
>> so a better
>> name describing the special purpose of the test might be helpful 
>> along with a
>> comment explaining the special purpose for the test.
>>
>> b/ The "test" part of the name is redundant
>
> Haha - OK
>
> The patch is already applied - I'll send a follow-up patch including 
> your suggestions.
>
> Thanks,
>
> - Greg
>
Darrell,

I've sent a patch out to fix this up.

Thanks,

- Greg


More information about the dev mailing list