[ovs-dev] [PATCH] tests: Only run test on kernel datapath

Ben Pfaff blp at ovn.org
Fri Oct 4 17:52:17 UTC 2019


On Fri, Oct 04, 2019 at 10:43:02AM -0700, Gregory Rose wrote:
> 
> On 10/4/2019 10:30 AM, Ben Pfaff wrote:
> > On Fri, Oct 04, 2019 at 09:49:57AM -0700, Greg Rose wrote:
> > > The recently added test to check for the correct L3 L4 protocol
> > > information after conntrack reassembles a packet should not run
> > > in the userspace datapath.  It is specific to a kernel datapath
> > > regression.
> > > 
> > > Also change the name of the test to make it more informativeand
> > > less redundant and add comments with a short explanation.
> > > 
> > > Fixes: d7fd61a ("tests: Add check for correct l3l4 conntrack frag reassembly")
> > > Suggested-by: Darrell Ball <dlu998 at gmail.com>
> > > Signed-off-by: Greg Rose <gvrose8192 at gmail.com>
> > Applied to master, thanks Greg and Darrell!
> > 
> > Greg, I noticed that you didn't CC Darrell on the patch.  You might find
> > it helpful to add the following to your ~/.gitconfig
> > 
> > [sendemail]
> > 	ccCmd = extract-ccs
> > 
> > and install the following in your $PATH as extract-ccs (marked
> > executable):
> > 
> > #! /bin/sed -nf
> > s/^[A-Z][-a-z]*-by: \(.*@.*\)/\1/p
> 
> My git send-email will extract CC's from 'Cc:' type fields but not
> Suggested-by as you say.  However, I did CC Darrell in the git
> send-email command itself:
> 
>  git send-email --to=dev at openvswitch.org --cc=dlu998 at gmail.com
> 0001-tests-Only-run-test-on-kernel-datapath.patch

Oh, that's odd, the CC does not show in the copy that reached me.
Puzzling.


More information about the dev mailing list