[ovs-dev] [PATCH] tests: Only run test on kernel datapath

Darrell Ball dlu998 at gmail.com
Fri Oct 4 18:20:26 UTC 2019


On Fri, Oct 4, 2019 at 11:03 AM Gregory Rose <gvrose8192 at gmail.com> wrote:

>
> On 10/4/2019 10:52 AM, Ben Pfaff wrote:
> > On Fri, Oct 04, 2019 at 10:43:02AM -0700, Gregory Rose wrote:
> >> On 10/4/2019 10:30 AM, Ben Pfaff wrote:
> >>> On Fri, Oct 04, 2019 at 09:49:57AM -0700, Greg Rose wrote:
> >>>> The recently added test to check for the correct L3 L4 protocol
> >>>> information after conntrack reassembles a packet should not run
> >>>> in the userspace datapath.  It is specific to a kernel datapath
> >>>> regression.
> >>>>
> >>>> Also change the name of the test to make it more informativeand
> >>>> less redundant and add comments with a short explanation.
> >>>>
> >>>> Fixes: d7fd61a ("tests: Add check for correct l3l4 conntrack frag
> reassembly")
> >>>> Suggested-by: Darrell Ball <dlu998 at gmail.com>
> >>>> Signed-off-by: Greg Rose <gvrose8192 at gmail.com>
> >>> Applied to master, thanks Greg and Darrell!
> >>>
> >>> Greg, I noticed that you didn't CC Darrell on the patch.  You might
> find
> >>> it helpful to add the following to your ~/.gitconfig
> >>>
> >>> [sendemail]
> >>>     ccCmd = extract-ccs
> >>>
> >>> and install the following in your $PATH as extract-ccs (marked
> >>> executable):
> >>>
> >>> #! /bin/sed -nf
> >>> s/^[A-Z][-a-z]*-by: \(.*@.*\)/\1/p
> >> My git send-email will extract CC's from 'Cc:' type fields but not
> >> Suggested-by as you say.  However, I did CC Darrell in the git
> >> send-email command itself:
> >>
> >>   git send-email --to=dev at openvswitch.org --cc=dlu998 at gmail.com
> >> 0001-tests-Only-run-test-on-kernel-datapath.patch
> > Oh, that's odd, the CC does not show in the copy that reached me.
> > Puzzling.
> Really?  I see he's not on the replies in this thread.  That is weird
> but I do see him on the CC line in my email.  Of course, I sent it...
>
> ???
>
> I've added Darrell back in here.  Darrell, did you get copied?
>

No, but it does not matter since I would not respond while driving anyways
:-)



>
> - Greg
>


More information about the dev mailing list