[ovs-dev] [PATCH v2] ci: Get rid of OVS_CFLAGS in CI scripts.
i.maximets at ovn.org
Fri Oct 4 18:43:12 UTC 2019
On 04.10.2019 19:31, Ben Pfaff wrote:
> On Fri, Oct 04, 2019 at 04:37:38PM +0200, Ilya Maximets wrote:
>> Our CI scripts uses OVS_CFLAGS variable that is intended for internal
>> usage by 'configure' script only. Usual CFLAGS should be used instead
>> to avoid giving bad example to users.
>> Additionally, '-m32' flag passed directly to CC variable to avoid
>> splitting it from the compiler invocations and force same API/ABI for
>> invocations of 'configure' and 'make'.
>> 'BUILD_ENV' dropped as not needed anymore.
>> Before this patch 'configure' always checked for 64bit libraries
>> regardless of fact that we're going to build 32bit binary. This
>> caused issues if only 64bit version of desired library was available.
>> Suggested-by: Ben Pfaff <blp at ovn.org>
>> Signed-off-by: Ilya Maximets <i.maximets at ovn.org>
>> Version 2:
>> * CFLAGS passed to './configure' where possible (except 'distcheck' case).
> Acked-by: Ben Pfaff <blp at ovn.org>
Thanks! I gave it one more run and applied to master.
Best regards, Ilya Maximets.
More information about the dev