[ovs-dev] [PATCH 2/2] backtrace: Fix 32-bit libunwind build.

William Tu u9012063 at gmail.com
Tue Oct 8 16:13:28 UTC 2019


On Mon, Oct 07, 2019 at 07:10:26PM +0200, Ilya Maximets wrote:
> On 07.10.2019 18:11, Ilya Maximets wrote:
> >On 07.10.2019 18:07, William Tu wrote:
> >>On Mon, Oct 7, 2019 at 5:06 AM Ilya Maximets <i.maximets at ovn.org> wrote:
> >>>
> >>>On 04.10.2019 23:21, William Tu wrote:
> >>>>The libunwind unw_word_t type is defined as uint32_t for 32-bit
> >>>>system and uint64_t for 64-bit system.  The patch fixes the
> >>>>compile error using PRIxPTR to print this value.
> >>>>
> >>>>Fixes: e2ed6fbeb18c ("fatal-signal: Catch SIGSEGV and print backtrace.")
> >>>>Signed-off-by: William Tu <u9012063 at gmail.com>
> >>>>Acked-by: Ilya Maximets <i.maximets at ovn.org>
> >>>>---
> >>>
> >>>Thanks! I applied both patches to master, but in the reverse order.
> >>>
> >>>Best regards, Ilya Maximets.
> >>
> >>Hi Ilya,
> >>
> >>Thanks...
> >>Now the cirrus CI and appveyor seem to be failing. I will work on it.
> >
> >Not sure about appveyor, but cirrus is failing because of this:
> >https://mail.openvswitch.org/pipermail/ovs-dev/2019-October/363182.html
> >
> >It's not related to current patch, freebsd just updated to use gcc > 9.
> >And it's not possible to build OVS with -Werror and gcc 9 right now.
> 
Thanks, I'm reviewing this patch.

> And this somehow FreeBSD specific. netinet/icmp6.h from glibc development
> package doesn't mark the structure as 'packed' on linux.
> 
> Best regards, Ilya Maximets.


The appveyor failure is not due to other issues.

Regards,
William


More information about the dev mailing list