[ovs-dev] [PATCH 2/2] backtrace: Fix 32-bit libunwind build.

William Tu u9012063 at gmail.com
Tue Oct 8 16:47:00 UTC 2019


On Tue, Oct 8, 2019 at 9:33 AM Ilya Maximets <i.maximets at ovn.org> wrote:
>
> On 08.10.2019 18:13, William Tu wrote:
> > On Mon, Oct 07, 2019 at 07:10:26PM +0200, Ilya Maximets wrote:
> >> On 07.10.2019 18:11, Ilya Maximets wrote:
> >>> On 07.10.2019 18:07, William Tu wrote:
> >>>> On Mon, Oct 7, 2019 at 5:06 AM Ilya Maximets <i.maximets at ovn.org> wrote:
> >>>>>
> >>>>> On 04.10.2019 23:21, William Tu wrote:
> >>>>>> The libunwind unw_word_t type is defined as uint32_t for 32-bit
> >>>>>> system and uint64_t for 64-bit system.  The patch fixes the
> >>>>>> compile error using PRIxPTR to print this value.
> >>>>>>
> >>>>>> Fixes: e2ed6fbeb18c ("fatal-signal: Catch SIGSEGV and print backtrace.")
> >>>>>> Signed-off-by: William Tu <u9012063 at gmail.com>
> >>>>>> Acked-by: Ilya Maximets <i.maximets at ovn.org>
> >>>>>> ---
> >>>>>
> >>>>> Thanks! I applied both patches to master, but in the reverse order.
> >>>>>
> >>>>> Best regards, Ilya Maximets.
> >>>>
> >>>> Hi Ilya,
> >>>>
> >>>> Thanks...
> >>>> Now the cirrus CI and appveyor seem to be failing. I will work on it.
> >>>
> >>> Not sure about appveyor, but cirrus is failing because of this:
> >>> https://mail.openvswitch.org/pipermail/ovs-dev/2019-October/363182.html
> >>>
> >>> It's not related to current patch, freebsd just updated to use gcc > 9.
> >>> And it's not possible to build OVS with -Werror and gcc 9 right now.
> >>
> > Thanks, I'm reviewing this patch.
> >
> >> And this somehow FreeBSD specific. netinet/icmp6.h from glibc development
> >> package doesn't mark the structure as 'packed' on linux.
> >>
> >> Best regards, Ilya Maximets.
> >
> >
> > The appveyor failure is not due to other issues.
>
> appveyor failure is due to missing python3 binary.
> Caused by the patch:
> 1ca0323e7c29 ("Require Python 3 and remove support for Python 2.")
>
> Need to add something like this to the build script:
>
> SET PYTHON="C:\\Python37-x64"
> SET PATH="%PYTHON%;%PYTHON%\\Scripts;%PATH%"
> python --version
>
> And revert back 's/python3/python/'.
>
> Best regards, Ilya Maximets.

Thanks! I'm testing it.
Also the link to download openssl is no longer available
https://slproweb.com/download/Win32OpenSSL-1_0_2n.exe

I'm testing this one (with 1.0.2t)
https://slproweb.com/download/Win32OpenSSL-1_0_2t.exe


More information about the dev mailing list